increased precision error buffer on delegator shares callback #933
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Context
Due to a rounding bug in the SDK, the number of tokens actually unbonded can be slightly less than the tokens specified when the undelegation was initiated. Stride's internal record keeping is adjusted based on what was initiated in the tx, so there can be a slight mismatch in the accounting.
The delegator shares slash query attempt to reconcile the magnitude of a slash by comparing the number of delegated tokens in the query response with the number of tokens stored internally. In the case of a slash, it is expecting the tokens from the query response to be less than the true delegation, and will normally decrement the internal record in accordance. However, if the response returns more tokens than what's stored internally, this will error for safety purposes.
To prevent an error from being thrown in the rounding bug scenario, there is a small cushion by which the response is allowed to differ by - this PR increases the buffer.
Brief Changelog
Author's Checklist
I have...
If skipped any of the tests above, explain.
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
Documentation and Release Note
Unreleased
section inCHANGELOG.md
?How is the feature or change documented?
XXX
x/<module>/spec/
)