Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICS loose ends #881

Merged
merged 19 commits into from
Aug 9, 2023
Merged

ICS loose ends #881

merged 19 commits into from
Aug 9, 2023

Conversation

sampocs
Copy link
Collaborator

@sampocs sampocs commented Aug 3, 2023

Context and purpose of the change

This PR involves whitelisting missing param keys and a helper function for registering stToken denoms to consumer whitelist.
stTokens need to be whitelisted on consumer chain to be flown to provider chain and distributed to hub validators.
These updates were originally included into this PR but we pulled ICS updates from the PR for the convenience.

Brief Changelog

  • Implement a function for registering stTokens as consumer rewards denom to the whitelist
  • Add missing param keys to proposal whitelist
  • Register stTokens to consumer reward denom whitelist automatically when new hostzones are added

Author's Checklist

  • Run and PASSED locally all integration tests.

@mergify
Copy link

mergify bot commented Aug 3, 2023

⚠️ The sha of the head commit of this PR conflicts with #860. Mergify cannot evaluate rules on this PR. ⚠️

1 similar comment
@mergify
Copy link

mergify bot commented Aug 3, 2023

⚠️ The sha of the head commit of this PR conflicts with #860. Mergify cannot evaluate rules on this PR. ⚠️

@asalzmann asalzmann self-requested a review August 8, 2023 12:53
@asalzmann
Copy link
Contributor

@strbrian can you add a more detailed description to this PR?

@strbrian
Copy link
Contributor

strbrian commented Aug 8, 2023

@strbrian can you add a more detailed description to this PR?

Updated the PR description.

Copy link
Contributor

@asalzmann asalzmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - we also discussed registering new denoms when a new host zone is added.

How are you thinking this will work?

app/proposals_whitelisting.go Show resolved Hide resolved
x/stakeibc/keeper/consumer.go Outdated Show resolved Hide resolved
Copy link
Contributor

@asalzmann asalzmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! when we start dockernet, stuatom should now be registered as a fee denom - let's verify that as we test the upgrade

@strbrian strbrian merged commit 089cfc5 into main Aug 9, 2023
@strbrian
Copy link
Contributor

strbrian commented Aug 9, 2023

lgtm! when we start dockernet, stuatom should now be registered as a fee denom - let's verify that as we test the upgrade

exactly, I actually already verified that as well.
once the dockernet is up, we can simply query consumer params using this link and check reward denom array.
http://localhost:1317/interchain_security/ccv/consumer/params

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants