-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make consumer running without going through ICS changeover #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strbrian
changed the title
enable consumer run without provider and ics channel locally
Make consumer running without going through ICS changeover
Jul 19, 2023
sampocs
approved these changes
Jul 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dockernet related changes look great, thanks for doing this!
Would be good to get @asalzmann's review on the chain changes
Integration test results:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context and purpose of the change
This PR is for running consumer without provider.
Since we changed our stride code to consumer, it can only run through changeover from sovereign to consumer.
When new feature/bug fixings are implemented, it will first require to build old sovereign binary and go through changeover to the new binary to test out things.
This is a bit time wasting and painful so its necessary to run consumer chain that doesn't rely on provider validators.
This PR is for customizing
add-consumer-section
CLI to compatible with our dockernet and modifying some docker scripts to achieve the goal.Brief Changelog
add-consumer-section
CLI to generate multiple initial validator sets based on number of validatorsAuthor's Checklist