Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make consumer running without going through ICS changeover #860

Merged
merged 14 commits into from
Aug 3, 2023

Conversation

strbrian
Copy link
Contributor

@strbrian strbrian commented Jul 19, 2023

Context and purpose of the change

This PR is for running consumer without provider.
Since we changed our stride code to consumer, it can only run through changeover from sovereign to consumer.
When new feature/bug fixings are implemented, it will first require to build old sovereign binary and go through changeover to the new binary to test out things.
This is a bit time wasting and painful so its necessary to run consumer chain that doesn't rely on provider validators.
This PR is for customizing add-consumer-section CLI to compatible with our dockernet and modifying some docker scripts to achieve the goal.

Brief Changelog

  • Customize add-consumer-section CLI to generate multiple initial validator sets based on number of validators
  • Update bash script to modify consumer genesis using the CLI
  • Disable adding gentxs to genesis file
  • Implement a function for registering stTokens as consumer rewards denom to the whitelist
  • Add missing param keys to proposal whitelist
  • Clean up dockernet scripts

Author's Checklist

  • Run and PASSED locally all integration tests except rewards distribution to stride governors.

@strbrian strbrian changed the title enable consumer run without provider and ics channel locally Make consumer running without going through ICS changeover Jul 19, 2023
@strbrian strbrian requested a review from sampocs July 31, 2023 16:38
Copy link
Collaborator

@sampocs sampocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dockernet related changes look great, thanks for doing this!

Would be good to get @asalzmann's review on the chain changes

@mergify mergify bot mentioned this pull request Aug 3, 2023
1 task
@sampocs
Copy link
Collaborator

sampocs commented Aug 3, 2023

Integration test results:

integration_tests.bats
 ✓ [INTEGRATION-BASIC-GAIA] host zones successfully registered
 ✓ [INTEGRATION-BASIC-GAIA] ibc transfer updates all balances
 ✓ [INTEGRATION-BASIC-GAIA] liquid stake mint and transfer
 ✓ [INTEGRATION-BASIC-GAIA] packet forwarding automatically liquid stakes
 ✓ [INTEGRATION-BASIC-GAIA] tokens on GAIA were staked
 ✓ [INTEGRATION-BASIC-GAIA] redemption works
 ✓ [INTEGRATION-BASIC-GAIA] claimed tokens are properly distributed
 ✓ [INTEGRATION-BASIC-GAIA] rewards are being reinvested, exchange rate updating
 ✓ [INTEGRATION-BASIC-GAIA] rewards are being distributed to stakers

9 tests, 0 failures

integration_tests.bats
 ✓ [INTEGRATION-BASIC-EVMOS] host zones successfully registered
 ✓ [INTEGRATION-BASIC-EVMOS] ibc transfer updates all balances
 ✓ [INTEGRATION-BASIC-EVMOS] liquid stake mint and transfer
 - [INTEGRATION-BASIC-EVMOS] packet forwarding automatically liquid stakes (skipped: Packet forward liquid stake test is only run on GAIA and HOST)
 ✓ [INTEGRATION-BASIC-EVMOS] tokens on EVMOS were staked
 ✓ [INTEGRATION-BASIC-EVMOS] redemption works
 ✓ [INTEGRATION-BASIC-EVMOS] claimed tokens are properly distributed
 ✓ [INTEGRATION-BASIC-EVMOS] rewards are being reinvested, exchange rate updating
 ✓ [INTEGRATION-BASIC-EVMOS] rewards are being distributed to stakers

9 tests, 0 failures, 1 skipped

integration_tests.bats
 ✓ [INTEGRATION-BASIC-HOST] host zones successfully registered
 ✓ [INTEGRATION-BASIC-HOST] ibc transfer updates all balances
 ✓ [INTEGRATION-BASIC-HOST] liquid stake mint and transfer
 ✓ [INTEGRATION-BASIC-HOST] packet forwarding automatically liquid stakes
 ✓ [INTEGRATION-BASIC-HOST] tokens on HOST were staked
 ✓ [INTEGRATION-BASIC-HOST] redemption works
 ✓ [INTEGRATION-BASIC-HOST] claimed tokens are properly distributed
 ✓ [INTEGRATION-BASIC-HOST] rewards are being reinvested, exchange rate updating
 ✓ [INTEGRATION-BASIC-HOST] rewards are being distributed to stakers

9 tests, 0 failures

@sampocs sampocs merged commit b8f62e5 into main Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants