Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add community pool rebate feature #1135

Merged
merged 15 commits into from
Mar 21, 2024
Merged

add community pool rebate feature #1135

merged 15 commits into from
Mar 21, 2024

Conversation

sampocs
Copy link
Collaborator

@sampocs sampocs commented Mar 15, 2024

Context

This feature provides the option for large community pool liquid stakes to be eligible for a rebate.

This PR will act as the base PR for this effort. Initial commits in this PR are only:

  • Proto changes to add the rebate to the host zone struct
  • Added helper on host zone to check if there is a rebate
  • Fixed misc lint errors (figured they were small enough that I'd just bundle them into this PR)

Remaining work for this feature will be in branched PRs, including:

  • Rebate calculation and fund community pool ICA
  • Tx to register a rebate
  • Txs to grant/revoke authz permissions
  • Disabling of ICA-enabled trading

ethan-stride
ethan-stride approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@ethan-stride ethan-stride left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@riley-stride
Copy link
Contributor

looking good so far

@sampocs sampocs requested review from asalzmann and shellvish March 18, 2024 20:20
@github-actions github-actions bot added the C:CLI label Mar 19, 2024
sampocs and others added 2 commits March 19, 2024 16:01
@sampocs
added toggle trade controller tx (#1142)
24a1367
@sampocs @riley-stride
rebate calculation and fund community pool ICA (#1136)
4724027 
Co-authored-by: riley-stride <104941670+riley-stride@users.noreply.github.com>
@riley-stride @sampocs
v20 host zone migration (add community pool treasury) (#1154)
609e0d2 
Co-authored-by: sampocs <sam.pochyly@gmail.com>
@sampocs sampocs changed the title [DRAFT] add community pool rebate feature add community pool rebate feature Mar 21, 2024
@sampocs sampocs marked this pull request as ready for review March 21, 2024 04:50
@sampocs sampocs merged commit 322cb10 into main Mar 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethan-stride ethan-stride ethan-stride approved these changes

@riley-stride riley-stride riley-stride left review comments

@asalzmann asalzmann asalzmann left review comments

@shellvish shellvish Awaiting requested review from shellvish

Assignees
No one assigned
Labels
C:app-wiring C:CLI C:proto C:stakeibc C:submodules T:build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sampocs @riley-stride @asalzmann @ethan-stride