disable trade route ICA swap #1137
Conversation
|
This will indeed stop the chain from doing swaps and I do think it is all that is needed. The 3 phase design we ended on means the swaps were their own phase and their callbacks don't exist. The third phase is still the return which exists in the TransferAllRewardTokens keeper function. But you could change the swap route types and all the associated tx routes to update trade routes if we are sure we won't want to go back since now they no longer need info for how to do the swaps like which pool and slippage params etc. If we think we might want to enable them again, then you can leave them be. |
|
Side note: because the return path does an ICQ only looking for DYDX tokens in the TradeAccount ICA it would ignore other tokens in there... so the operator could actually do multiple swaps if they thought it would give a better price. Eg. Swap USDC for OSMO then swap the OSMO for DYDX |
Small one here but definitely double check me that this is all we have to do to disable the swaps.