Update AggregateMessageOrigin #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claravanstaden
commented
Nov 24, 2023
|
@claravanstaden Just made some fixes for the compile error and failed tests, changes mainly in Snowfork/polkadot-sdk#39, hope it's helpful and happy weekend |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1024 +/- ##
==========================================
- Coverage 81.06% 80.97% -0.10%
==========================================
Files 52 52
Lines 2150 2150
Branches 67 67
==========================================
- Hits 1743 1741 -2
- Misses 392 394 +2
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@yrong thank you, I appreciate it! 😄 |
3c944df to
fceb2ec
Compare
alistair-singh
approved these changes
Nov 28, 2023
b33b363 to
f5aa978
Compare
a216b39 to
a2929b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: SNO-747
Polkadot-sdk companion: Snowfork/polkadot-sdk#38