This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
Fix compile error & breaking tests #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e26d6fa to
a94b564
Compare
| ); | ||
| }); | ||
| } | ||
| // #[test] |
There was a problem hiding this comment.
This test probably shouldn't be commented out, right?
There was a problem hiding this comment.
Yes, this is the test I commented out for some breaking changes. I should uncomment and fix it in some way.
857549a to
040a388
Compare
e9fd347
into
update-aggregate-message-origin
4 of 8 checks passed
claravanstaden
pushed a commit
that referenced
this pull request
Nov 28, 2023
claravanstaden
added a commit
that referenced
this pull request
Nov 28, 2023
* update aggregate message origin * fix imports * fmt * revert non-rococo changes * adds log * Fix compile error & breaking tests (#39) * westend needs the same config * revert log * add test back in * revert fmt * Fix breaking test --------- Co-authored-by: claravanstaden <Cats 4 life!> Co-authored-by: Ron <yrong1997@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✄ -----------------------------------------------------------------------------
Thank you for your Pull Request! 🙏 Please make sure it follows the contribution guidelines outlined in
this document and fill
out the sections below. Once you're ready to submit your PR for review, please
delete this section and leave only the text under the "Description" heading.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context,
including:
Use Github semantic
linking
to address any open issues this PR relates to or closes.
Fixes # (issue number, if applicable)
Closes # (issue number, if applicable)
Checklist
Trequired)
You can remove the "Checklist" section once all have been checked. Thank you for your contribution!
✄ -----------------------------------------------------------------------------