Fixes #1321 Prevent js errors if tracker blocked (2.6.x) #1336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by browser plugin (ex: ublock origin)
|
You might want to rename tracking.js - i did to fracking.js to avoid the ublock in the first place! |
|
Yes, I Regards, |
|
Yes, we'll probably have to rename the tracker file. But actually the try/catch is a proper workaround, and it should be here in any cases (we cannot break all pages due to tracking, whatever causes it to crash). |
|
Fix #1321 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by browser plugin (ex: ublock origin)