Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS errors and non working search with enabled ublock origin #1321

Closed
Wohlie opened this issue Feb 21, 2019 · 2 comments
Closed

JS errors and non working search with enabled ublock origin #1321

Wohlie opened this issue Feb 21, 2019 · 2 comments
Assignees

Comments

@Wohlie
Copy link

Wohlie commented Feb 21, 2019

Hi,

i use chrome with enabled ublock origin as adblocker with this configuration:
ublock

In this case is get js errors, because the js file ...Smile_ElasticsuiteTracker/js/tracking.js is blocked:
jserrors

The bigger problem is, also the search function is not working in case of the js errors.

Fix:
Add a try catch to all smileTracker calls.

@rbayet
Copy link
Collaborator

rbayet commented Feb 21, 2019

Hello @Wohlie,

Can you provide the version of Magento2 and ElasticSuite you are using (I know it might not relevant, but still) and on which Chrome version/platform you are using ?

On M2 2.3.0, I can reproduce the first issue with ublock origin installed in Chromium 65 on Ubuntu but the autocomplete search is not blocked.
Can you detail that additional error ?

Regards,

rbayet added a commit to rbayet/elasticsuite that referenced this issue Feb 21, 2019
by browser plugin (ex: ublock origin)
rbayet added a commit to rbayet/elasticsuite that referenced this issue Feb 27, 2019
by browser plugin (ex: ublock origin)
rbayet added a commit to rbayet/elasticsuite that referenced this issue Feb 27, 2019
by browser plugin (ex: ublock origin)
romainruaud added a commit that referenced this issue Mar 1, 2019
…if-blocked-2.6.x

Fixes #1321 Prevent js errors if tracker blocked (2.6.x)
romainruaud added a commit that referenced this issue Mar 1, 2019
…if-blocked

Fixes #1321 Prevent js errors if tracker blocked (2.7.x)
@romainruaud
Copy link
Collaborator

Fixed by associated PR, will be part of next minor releases 2.6.7 & 2.7.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants