Fixes #1189 Missing dropdown attributes values #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7308e26 to
ee6cd81
Compare
Part 1: when Magento_Swatches/Smile_ElasticsuiteSwatches are enabled Modules' declared dependencies are not enough to make sure the following order of layout files is achieved : - Magento_Catalog - Smile_ElasticsuiteCatalog - Magento_Swatches - Smile_ElasticsuiteSwatches which would be the only order not requiring Smile_ElasticsuiteSwatches to re-declare the setTemplate on attribute_edit_js
Part 2: when Magento_Swatches/Smile_ElasticsuiteSwatches are disabled Note: possible non-working native code ?
ee6cd81 to
aab21b7
Compare
romainruaud
approved these changes
Nov 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1: when Magento_Swatches/Smile_ElasticsuiteSwatches are enabled