Dropdown attribute values not displaying in adminhtml #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix extra ) causing error in Browser
This is probably the wrong way of doing it, but it works. I migrated from 1.9.2.2 to 2.2.6, and when I go to stores -> Attributes -> Product, and select a attribute with a dropdown type, I see no attributes in there. If I add them they show up in the front end, Cannot remove any (because they are not there) Disabling Smile_ElasticsuiteCatalog fixes the issue. Diffing the HTML output with Smile_ElasticsuiteCatalog enabled and disabled reveals that this code is missing.
|
Hello, thank you for reporting it. However, it's more complex than the fix you provided here. In fact Magento moved a lot of code from the We did not notice this point, so thank you for pointing us to this issue. I keep your PR open as a reminder to fix it on a nice way, but will not merge your solution as is. Regards |
|
Your PR has been superceded by #1191 which has been merged into 2.6.x and slated for release in 2.6.x Regards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I migrated from 1.9.2.2 to 2.2.6, and when I go to stores -> Attributes -> Product, and select a attribute with a dropdown type, I see no attribute values in there. For example, if I had an attribute color, I would not see any migrated Values of "Blue", "Red", etc under "Manage Options".
Creating a new attribute with dropdowns would yield the same behavior.
Any new or existing values would appear in the front end and the product pages, so I know they were saving.
If I add any new values, It would save, but upon refresh would disappear.
Creating a whole new attribute had the same issue.
I however, could not delete any values, because they were not populating.
Disabling Smile_ElasticsuiteCatalog fixes the issue.
Commit 1bcebbe did not appear to fix the issue, just cleaning up noise in the browser Javascript console.
Commit 489cfce ultimately fixed the issue, but it smells pretty bad. When doing a diff of the product attribute page with Smile_ElasticsuiteCatalog enabled and then disabled, I noticed this code missing, so I stuffed it in here. I am sure there is a better fix.