Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ThirdReality Smart Soil Moisture Sensor #1937

Merged
merged 5 commits into from
Feb 25, 2025
Merged

add ThirdReality Smart Soil Moisture Sensor #1937

merged 5 commits into from
Feb 25, 2025

Conversation

weihuan1111
Copy link
Contributor

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 17, 2025 •
edited
Loading

Channel deleted.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 17, 2025 •
edited
Loading

Test Results

   64 files  ±0    410 suites  ±0   0s ⏱️ ±0s
2 067 tests ±0  2 067 ✅ ±0  0 💤 ±0  0 ❌ ±0 
3 546 runs  ±0  3 546 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit b55c1d4. ± Comparison against base commit d649f75.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 17, 2025 •
edited
Loading

File Coverage
All files 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-humidity-sensor/src/aqara/init.lua 93% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-humidity-sensor/src/plant-link/init.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-humidity-sensor/src/init.lua 94% ✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against b55c1d4

@weihuan1111 weihuan1111 changed the title Update fingerprints.yml add ThirdReality Smart Soil Moisture Sensor Feb 17, 2025
@lelandblue lelandblue merged commit a7aea22 into SmartThingsCommunity:main Feb 25, 2025
11 checks passed
cjswedes pushed a commit that referenced this pull request Mar 3, 2025
@weihuan1111 @lelandblue @cjswedes
add ThirdReality Smart Soil Moisture Sensor (#1937)
e3b59e4 
* Update fingerprints.yml

* Update cn.csv

* Update cn.csv

---------

Co-authored-by: Alissa Dornbos <79465613+lelandblue@users.noreply.github.com>
@weihuan1111 weihuan1111 mentioned this pull request Mar 6, 2025
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbaumler cbaumler cbaumler approved these changes

@lelandblue lelandblue lelandblue approved these changes

@greens greens Awaiting requested review from greens

@wkhenon wkhenon Awaiting requested review from wkhenon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weihuan1111 @cbaumler @lelandblue