Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add thirdreality TH sensor #1927

Merged
merged 15 commits into from
Mar 7, 2025
Merged

Conversation

weihuan1111
Copy link
Contributor

Change-Id: If8ea228f444b72775317f0ed3f54c05766e75835

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

Change-Id: If8ea228f444b72775317f0ed3f54c05766e75835
Copy link

github-actions bot commented Feb 12, 2025

Channel deleted.

Copy link

github-actions bot commented Feb 12, 2025

Test Results

   64 files    414 suites   0s ⏱️
2 091 tests 2 091 ✅ 0 💤 0 ❌
3 583 runs  3 583 ✅ 0 💤 0 ❌

Results for commit 94a5107.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 12, 2025

File Coverage
All files 97%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-humidity-sensor/src/aqara/init.lua 93%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-humidity-sensor/src/init.lua 94%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-humidity-sensor/src/plant-link/init.lua 97%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 94a5107

@weihuan1111 weihuan1111 changed the title test add thirdreality TH sensor Feb 14, 2025
@lelandblue
Copy link
Contributor

Hey @weihuan1111 . Would you like us to start a review on this change?

@weihuan1111
Copy link
Contributor Author

Hey @weihuan1111 . Would you like us to start a review on this change?

Yes. @lelandblue

Copy link
Contributor

@lelandblue lelandblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add changes to the translation file for this device so that we can provide a device label translation value.

Thanks

@weihuan1111
Copy link
Contributor Author

Please also add changes to the translation file for this device so that we can provide a device label translation value.

Thanks

@lelandblue
You mean this? this has already been merged in PR #1937
image

@lelandblue lelandblue merged commit 796a29d into SmartThingsCommunity:main Mar 7, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants