Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure objects are created in a consistent way without pointers #85

Merged
merged 1 commit into from
May 18, 2021
Merged

Ensure objects are created in a consistent way without pointers #85

merged 1 commit into from
May 18, 2021

Conversation

Smirl
Copy link
Contributor

@Smirl Smirl commented May 18, 2021

Summary

@Smirl Smirl requested a review from maruina May 18, 2021 14:38
@maruina
Copy link
Contributor

maruina commented May 18, 2021

Did you have a look at the controller as well?

maruina
maruina approved these changes May 18, 2021
View reviewed changes
Copy link
Contributor

@maruina maruina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maruina maruina merged commit 5aaf2c4 into main May 18, 2021
@maruina maruina deleted the consistent-object-declaration branch May 18, 2021 19:37
@maruina maruina mentioned this pull request May 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maruina maruina maruina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent object declaration
2 participants
@Smirl @maruina