We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We are not consistent when we declare a new object.
Sometimes we do something like
pr := deploymentskyscannernetv1alpha1.ProgressiveRollout{}
and sometimes we do
pr := &deploymentskyscannernetv1alpha1.ProgressiveRollout{}
We agreed on using the first format because then it's very explicit when you need to pass a reference to it. For example
if err := r.Get(ctx, req.NamespacedName, &pr); err != nil {...}
is more clear then
if err := r.Get(ctx, req.NamespacedName, pr); err != nil {...}
The text was updated successfully, but these errors were encountered:
Smirl
Successfully merging a pull request may close this issue.
We are not consistent when we declare a new object.
Sometimes we do something like
and sometimes we do
We agreed on using the first format because then it's very explicit when you need to pass a reference to it. For example
is more clear then
The text was updated successfully, but these errors were encountered: