Improve ItemMeta comparisons #5374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certainly not ideal
TheLimeGlass
approved these changes
Feb 2, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to improve ItemData's ItemMeta comparisons.
Just like the existing implementation, this new one is not exactly ideal. Because Skript manually checks certain parts of the ItemData, we do not want to check it again during our ItemMeta comparisons (this may result in an incorrect result). This is solved by cloning the second ItemMeta and setting its properties to match those of the first ItemMeta. If anyone has a better solution, please feel free to share it :)
Target Minecraft Versions: any
Requirements: N/A
Related Issues: