Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goat horn variants don't work #4882

Closed
1 task done
TPGamesNL opened this issue Jul 8, 2022 · 3 comments
Closed
1 task done

Goat horn variants don't work #4882

TPGamesNL opened this issue Jul 8, 2022 · 3 comments
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.

Comments

@TPGamesNL
Copy link
Member

TPGamesNL commented Jul 8, 2022

Skript/Server Version

2.6.3
or at least commit from https://github.com/SkriptLang/Skript/pull/4881

Bug Description

Using sing goat horn gives the ponder goat horn instead, all aliases give the ponder variant.

This is because the de-duplication mechanism of aliases loading (AliasesProvider#L295) sees the ponder goat horn and the sing goat horn as equal. This is in turn because they're both minecraft:goat_horn, and Bukkit doesn't have a goat horn ItemMeta yet (https://hub.spigotmc.org/jira/browse/SPIGOT-7034), which means Skript doesn't have a way to see the difference between the item metas.

When Bukkit adds this, we may have to modify ItemData#compareItemMetas to be able to compare goat horn metas, but it'll have to be tested then.

Expected Behavior

not to do that

Steps to Reproduce

!give sing goat horn to me

Errors or Screenshots

No response

Other

No response

Agreement

  • I have read the guidelines above and affirm I am following them with this report.
@TPGamesNL TPGamesNL added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: low Issues that are not harmful to the experience but are related to useful changes or additions. labels Jul 8, 2022
@AyhamAl-Ali AyhamAl-Ali added the aliases For mistakes or requested additions in the aliases themselves, not the code driving the aliases. label Jul 8, 2022
@TPGamesNL TPGamesNL removed the aliases For mistakes or requested additions in the aliases themselves, not the code driving the aliases. label Jul 10, 2022
@TheLimeGlass
Copy link
Contributor

It's actually Mojang that pushed 1.19 with unfinished features, so Spigot/Bukkit is waiting to see what Mojang will do, like how the Shrieker block did have a dedicated packet in the snapshots, but when release came out, Mojang remove it and merged it into generic events for the time being. 1.19 was not properly constructed.

@APickledWalrus APickledWalrus added the PR available Issues which have a yet-to-be merged PR resolving it label Jan 20, 2023
@APickledWalrus
Copy link
Member

Oh I think this has been fixed but we will need to confirm

@TheLimeGlass
Copy link
Contributor

fixed

@TheLimeGlass TheLimeGlass added completed The issue has been fully resolved and the change will be in the next Skript update. and removed PR available Issues which have a yet-to-be merged PR resolving it labels Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.
Projects
None yet
Development

No branches or pull requests

4 participants