Damage effect fixes

[TPGamesNL]

Description

• Reverts Change the damage effect calling EntityDamageEvent twice #3719, instead remove the event call entirely, as it was only a hotfix for a long-fixed CraftBukkit bug.
• Removes the fake damage cause part of the damage effect, because there's no way to implement it (it probably previously worked because of the aforementioned bug). If you want to retain the functionality, set the last damage cause after the damage effect.
• Reverts Fix damaging items #2836 and fixes it properly (init method matched return type against ItemStack, should be ItemType).

---

Target Minecraft Versions: any
Requirements: none
Related Issues: #3997, #3715 (also #3719, #2755, #2836)

[Jjman739]

Removes the fake damage cause part of the damage effect, because there's no way to implement it (it probably previously worked because of the aforementioned bug). If you want to retain the functionality, set the last damage cause after the damage effect.

In my testing, I was able to get it to work, with the caveat that the damage effect processes twice (first for the designated cause and then again for "unknown" if the first was not cancelled.) Are you sure there's no way?

I was going to do more research to see if I could get it to only call the damage once.

[TPGamesNL]

The first event call you had, was from Skript calling the event manually (which I removed, as it shouldn't do this). The second is the actual event being called from your server, the damage cause of which cannot be set without reflection (and probably NMS).

[Jjman739]

Yeah... upon further analysis, I noticed that the event call doesn't deal the damage directly, instead only being used to check if the event is being cancelled.

Why shouldn't it call the event manually, though? If the damage event can be made to apply the damage, that should solve the issue, unless I'm misunderstanding the way Bukkit events work.

[TPGamesNL]

Bukkit events are only called to let plugins know something happened, no internal server stuff relies on events being called. The player will therefore not be damaged if an event is called, all it will do is confuse other plugins (and scripts), because it seems like the player is taking damage twice, even though it's only once.

EDIT: well done on the debugging and testing, by the way 👍

[Jjman739]

(Thanks)

It's probably too hacky to have it call the event and then play the hit animation and reduce the HP directly in accordance with the final damage amount, right?

[TPGamesNL]

It's probably too hacky to have it call the event and then play the hit animation and reduce the HP directly in accordance with the final damage amount, right?

Yep

[APickledWalrus]

Looks good to me!