Add on leave to quit event (#3789) #3799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. as an alternative to quit, disconnect and logout. Will handle leave, leaving and their variants with "on" prefix. (ScriptLoader adds that, no need to specify here)
|
just thinking out loud I'm not sure if this is actually a good add because edit: nevermind my reading comprehension failed me |
Whimsyturtle
approved these changes
Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
.. as an alternative to quit, disconnect and logout.
Will handle leave, leaving and their variants with "on" prefix. (ScriptLoader adds that, no need to specify here)
Not sure if tests are required for a change like this; not familiar with the testing system but can add one that ensures on quit, on disconnect, on logout and on leave parses successfully (if that is possible).
Target Minecraft Versions: any
Requirements: none
Related Issues: #3789