Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add on leave #3789

Closed
quick007 opened this issue Mar 5, 2021 · 3 comments
Closed

add on leave #3789

quick007 opened this issue Mar 5, 2021 · 3 comments
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something. good first issue An issue that would be good for a first-time contributor to make a PR for priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).

Comments

@quick007
Copy link

quick007 commented Mar 5, 2021

According to the parser at least, on leave: isn't an event. I think it would be nice to add this as another of using on disconnect:.
@TheDGOfficial
Copy link
Contributor

TheDGOfficial commented Mar 5, 2021 via email •
edited
Loading

@APickledWalrus
Copy link
Member

Wouldn't hurt to have. Here is the registration line for this event:

Skript/src/main/java/ch/njol/skript/events/SimpleEvents.java

Line 310 in 885a4b6

Skript.registerEvent("Quit", SimpleEvent.class, PlayerQuitEvent.class, "(quit[ting]|disconnect[ing]|log[ ]out|logging out)")

@APickledWalrus APickledWalrus added enhancement Feature request, an issue about something that could be improved, or a PR improving something. good first issue An issue that would be good for a first-time contributor to make a PR for priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements). labels Mar 6, 2021
@quick007
Copy link
Author

quick007 commented Mar 6, 2021

Simple to add, you can open a PR or I can look when I have time. Might be

checked the docs actually, on leave: seems to be unused

TheDGOfficial pushed a commit to TheDGOfficial/Skript that referenced this issue Mar 8, 2021
Add on leave to quit event (SkriptLang#3789)
1c2f917 
.. as an alternative to quit, disconnect and logout.

Will handle leave, leaving and their variants with "on" prefix. (ScriptLoader adds that, no need to specify here)
@TheDGOfficial TheDGOfficial mentioned this issue Mar 8, 2021
Merged
@Whimsyturtle Whimsyturtle added the completed The issue has been fully resolved and the change will be in the next Skript update. label Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something. good first issue An issue that would be good for a first-time contributor to make a PR for priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Whimsyturtle @ShaneBeee @TheDGOfficial @APickledWalrus @quick007