Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update puppeteer #60

Merged
merged 5 commits into from
Jul 29, 2024
Merged

Update puppeteer #60

merged 5 commits into from
Jul 29, 2024

Conversation

Jym77
Copy link
Contributor

@Jym77 Jym77 commented Jul 29, 2024

Update puppeteer and replace deprecated awaiters in the scraper.

  • waitForXPath has been replaced by the equivalent waitForSelector("xpath/" + expression).
  • waitForTimeout has been replace by regular node setTimeout call.
  • A note on timeout being unreliably is added to the flag description (this is the reason why it's been removed in puppeteer; we still want that shortcut in Alfa scraper for convenience but should not use it where reliability is important).

@Jym77 Jym77 self-assigned this Jul 29, 2024
Copy link

changeset-bot bot commented Jul 29, 2024

⚠️ No Changeset found

Latest commit: d262521

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Jym77 Jym77 added dependencies Related to dependencies patch Backwards-compatible change that doesn't touch public API labels Jul 29, 2024
@Jym77 Jym77 marked this pull request as ready for review July 29, 2024 09:13
@Jym77 Jym77 requested a review from a team as a code owner July 29, 2024 09:13
@Jym77 Jym77 merged commit 7382cf9 into main Jul 29, 2024
4 checks passed
@Jym77 Jym77 deleted the update-puppeteer branch July 29, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Related to dependencies patch Backwards-compatible change that doesn't touch public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant