Update puppeteer (#60)

* Update puppeteer * Replace deprecated waitForXPath * Replace deprecated waitForTimeOut * Clean up
Siteimprove · Jul 29, 2024 · 7382cf9 · 7382cf9
1 parent 65a5f56
commit 7382cf9
Show file tree

Hide file tree

Showing 5 changed files with 131 additions and 167 deletions.
diff --git a/packages/alfa-cli/src/alfa/command/scrape/flags.ts b/packages/alfa-cli/src/alfa/command/scrape/flags.ts
@@ -112,7 +112,10 @@ export const Flags = {
 
   awaitDuration: Flag.integer(
     "await-duration",
-    "The duration to wait before considering the page loaded."
+    `The duration to wait before considering the page loaded.
+    Note that waiting for fixed durations creates race conditions and is less
+    reliable than other awaiters. This flag must be used with caution, especially
+    in settings where reliability is important (production, automated tests, …)`
   )
     .type("milliseconds")
     .optional(),

diff --git a/packages/alfa-puppeteer/package.json b/packages/alfa-puppeteer/package.json
@@ -26,7 +26,7 @@
     "@siteimprove/alfa-dom": "^0.88.0",
     "@siteimprove/alfa-http": "^0.88.0",
     "@siteimprove/alfa-web": "^0.88.0",
-    "puppeteer": "^19.9.1"
+    "puppeteer": "^22.14.0"
   },
   "peerDependencies": {
     "@siteimprove/alfa-device": "^0.88.0",

diff --git a/packages/alfa-scraper/package.json b/packages/alfa-scraper/package.json
@@ -37,7 +37,7 @@
     "@siteimprove/alfa-time": "^0.88.0",
     "@siteimprove/alfa-url": "^0.88.0",
     "@siteimprove/alfa-web": "^0.88.0",
-    "puppeteer": "^19.9.1"
+    "puppeteer": "^22.14.0"
   },
   "devDependencies": {
     "@siteimprove/alfa-test": "^0.88.0"

diff --git a/packages/alfa-scraper/src/awaiter.ts b/packages/alfa-scraper/src/awaiter.ts
@@ -112,7 +112,9 @@ export namespace Awaiter {
       const error = await after(page, timeout);
 
       if (error.isNone()) {
-        await page.waitForTimeout(duration);
+        await new globalThis.Promise(function (resolve) {
+          setTimeout(resolve, duration);
+        });
       }
 
       return error;
@@ -144,7 +146,7 @@ export namespace Awaiter {
   export function xpath(expression: string): Awaiter {
     return async (page, timeout) => {
       try {
-        await page.waitForXPath(expression, {
+        await page.waitForSelector("xpath/" + expression, {
           timeout: timeout.remaining(),
         });