✨ add schema generation for customer account api in hydrogen-react ‰… #1572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7abe11b to
c42c793
Compare
frandiox
reviewed
Dec 14, 2023
Comment on lines
+7
to
+8
| const SF_API_VERSION = '2023-10'; | ||
| const CA_API_VERSION = '2024-01'; |
There was a problem hiding this comment.
😬 should we release this in 2024.1.0 to honor the CAAPI version?
Or at least mention explicitly that this is still unstable/release candidate, and that the stable will come in 2024.1.0?
There was a problem hiding this comment.
I would like to do the update for SFAPI version on a separate PR because there are so much involved (updating hydrogen version and all the doc links) and this PR has enough file changes as it is. I will update the changelog with the unstable information thou!
frandiox
approved these changes
Dec 14, 2023
e3bcf45 to
247db5c
Compare
…d export these types in both hydrogen-react & hydrogen.
247db5c to
29252f1
Compare
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…and export these types in both hydrogen-react & hydrogen.
Related PR: #1569
WHY are these changes introduced?
This is needed to fetch and use customer account api schema types.
WHAT is this pull request doing?
graphql-typescommand in hydrogen-react now generate two additional filescustomer.schema.json&src/customer-account-api-types.d.tswhich is the schema & the schema types from Customer Account API.Both of those files are being exported in hydrogen-react & hydrogen package.
HOW to test your changes?
There is nothing to test just yet
Post-merge steps
Checklist