-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support customer account API in hydrogen-codegen #1569
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I prefer explicit setting over options thats abstracted away. Curious just for my context where else we are using @shopify/hydrogen-codegen
. So far I only found one usage in cli.
Also, dont forget changelog!
Co-authored-by: Michelle Chen <michelle.chen@shopify.com>
Other teams are using it for Admin API and other stuff. Plus, it can be used by users directly if they want to add extra configuration for 3p APIs (e.g. a CMS). They can just have their own |
Thank you for the explanation @frandiox ! If possible, I think a README in the |
Yeah, pending task before we release v1 and write proper docs! For that, I'm waiting for dotansimha/graphql-code-generator#9709 to be released first so that we can stop patching depenendcies. I guess we can add the example of this PR to the readme for now 🤔 |
This PR only adds default values for Customer Account API in hydrogen-codegen just like we have for Storefront API.
Usage in
codegen.ts
: