Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banner/Email banner follow ups #990

Merged
merged 1 commit into from
Dec 10, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion assets/section-email-signup-banner.css
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@

.banner--desktop-transparent .email-signup-banner__box--no-image .field__button:focus-visible {
outline: 0.2rem solid rgba(var(--color-base-text), 0.5);
outline-offset: 0.3rem;
box-shadow: 0 0 0 0.3rem rgb(var(--color-background)),
0 0 0.5rem 0.4rem rgba(var(--color-base-text), 0.3);
}
Expand Down
20 changes: 10 additions & 10 deletions assets/section-image-banner.css
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,16 @@
width: 100%;
}

.banner__content {
padding: 0;
display: flex;
position: relative;
width: 100%;
align-items: center;
justify-content: center;
z-index: 2;
}

@media screen and (min-width: 750px) {
.banner__content {
padding: 5rem;
Expand Down Expand Up @@ -240,16 +250,6 @@
}
}

.banner__content {
padding: 0;
display: flex;
position: relative;
width: 100%;
align-items: center;
justify-content: center;
z-index: 2;
}

@media screen and (max-width: 749px) {
.banner--mobile-bottom:not(.banner--stacked) .banner__content {
order: 2;
Expand Down
3 changes: 0 additions & 3 deletions locales/cs.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -2081,9 +2081,6 @@
"options__2": {
"label": "Podtitul"
},
"options__3": {
"label": "Velká písmena"
},
"label": "Textový styl"
}
}
Expand Down
3 changes: 0 additions & 3 deletions locales/da.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -2081,9 +2081,6 @@
"options__2": {
"label": "Undertekst"
},
"options__3": {
"label": "Store bogstaver"
},
"label": "Teksttypografi"
}
}
Expand Down
3 changes: 0 additions & 3 deletions locales/de.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -2081,9 +2081,6 @@
"options__2": {
"label": "Untertitel"
},
"options__3": {
"label": "Großbuchstaben"
},
"label": "Textstil"
}
}
Expand Down
3 changes: 0 additions & 3 deletions locales/en.default.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -1925,9 +1925,6 @@
"options__2": {
"label": "Subtitle"
},
"options__3": {
"label": "Uppercase"
},
"label": "Text style"
}
}
Expand Down
3 changes: 0 additions & 3 deletions locales/es.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -2081,9 +2081,6 @@
"options__2": {
"label": "Subtítulo"
},
"options__3": {
"label": "Mayúscula"
},
"label": "Estilo de texto"
}
}
Expand Down
3 changes: 0 additions & 3 deletions locales/fi.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -2081,9 +2081,6 @@
"options__2": {
"label": "Alaotsikko"
},
"options__3": {
"label": "Isot kirjaimet"
},
"label": "Tekstityyli"
}
}
Expand Down
3 changes: 0 additions & 3 deletions locales/fr.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -2081,9 +2081,6 @@
"options__2": {
"label": "Sous-titre"
},
"options__3": {
"label": "Majuscule"
},
"label": "Style de texte"
}
}
Expand Down
3 changes: 0 additions & 3 deletions locales/it.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -2081,9 +2081,6 @@
"options__2": {
"label": "Sottotitolo"
},
"options__3": {
"label": "Maiuscolo"
},
"label": "Stile del testo"
}
}
Expand Down
3 changes: 0 additions & 3 deletions locales/ja.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -2081,9 +2081,6 @@
"options__2": {
"label": "字幕"
},
"options__3": {
"label": "大文字"
},
"label": "テキストスタイル"
}
}
Expand Down
3 changes: 0 additions & 3 deletions locales/ko.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -2081,9 +2081,6 @@
"options__2": {
"label": "소제목"
},
"options__3": {
"label": "대문자"
},
"label": "텍스트 스타일"
}
}
Expand Down
3 changes: 0 additions & 3 deletions locales/nb.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -2081,9 +2081,6 @@
"options__2": {
"label": "Undertekst"
},
"options__3": {
"label": "Store bokstaver"
},
"label": "Tekststil"
}
}
Expand Down
3 changes: 0 additions & 3 deletions locales/nl.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -2081,9 +2081,6 @@
"options__2": {
"label": "Subtitel"
},
"options__3": {
"label": "Hoofdletters"
},
"label": "Tekststijl"
}
}
Expand Down
3 changes: 0 additions & 3 deletions locales/pl.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -2081,9 +2081,6 @@
"options__2": {
"label": "Podtytuł"
},
"options__3": {
"label": "Duże litery"
},
"label": "Styl tekstu"
}
}
Expand Down
3 changes: 0 additions & 3 deletions locales/pt-BR.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -2081,9 +2081,6 @@
"options__2": {
"label": "Legenda"
},
"options__3": {
"label": "Letras maiúsculas"
},
"label": "Estilo de texto"
}
}
Expand Down
3 changes: 0 additions & 3 deletions locales/pt-PT.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -2081,9 +2081,6 @@
"options__2": {
"label": "Legenda"
},
"options__3": {
"label": "Maiúsculas"
},
"label": "Estilo de texto"
}
}
Expand Down
3 changes: 0 additions & 3 deletions locales/sv.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -2081,9 +2081,6 @@
"options__2": {
"label": "Underrubrik"
},
"options__3": {
"label": "Stora bokstäver"
},
"label": "Textstil"
}
}
Expand Down
3 changes: 0 additions & 3 deletions locales/th.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -2081,9 +2081,6 @@
"options__2": {
"label": "คำบรรยาย"
},
"options__3": {
"label": "ตัวพิมพ์ใหญ่"
},
"label": "รูปแบบข้อความ"
}
}
Expand Down
3 changes: 0 additions & 3 deletions locales/tr.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -2081,9 +2081,6 @@
"options__2": {
"label": "Alt yazı"
},
"options__3": {
"label": "Büyük harf"
},
"label": "Metin stili"
}
}
Expand Down
3 changes: 0 additions & 3 deletions locales/vi.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -2081,9 +2081,6 @@
"options__2": {
"label": "Tiêu đề"
},
"options__3": {
"label": "Chữ viết hoa"
},
"label": "Kiểu văn bản"
}
}
Expand Down
3 changes: 0 additions & 3 deletions locales/zh-CN.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -2081,9 +2081,6 @@
"options__2": {
"label": "副标题"
},
"options__3": {
"label": "大写"
},
"label": "文本样式"
}
}
Expand Down
3 changes: 0 additions & 3 deletions locales/zh-TW.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -2081,9 +2081,6 @@
"options__2": {
"label": "副標題"
},
"options__3": {
"label": "大寫"
},
"label": "文字樣式"
}
}
Expand Down
4 changes: 0 additions & 4 deletions sections/email-signup-banner.liquid
Original file line number Diff line number Diff line change
Expand Up @@ -332,10 +332,6 @@
{
"value": "subtitle",
"label": "t:sections.email-signup-banner.blocks.paragraph.settings.text_style.options__2.label"
},
{
"value": "caption-with-letter-spacing",
"label": "t:sections.email-signup-banner.blocks.paragraph.settings.text_style.options__3.label"
}
],
"default": "body",
Expand Down