Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banner/Email banner follow ups #990

Merged
merged 1 commit into from
Dec 10, 2021
Merged

Banner/Email banner follow ups #990

merged 1 commit into from
Dec 10, 2021

Conversation

sofiamatulis
Copy link
Contributor

@sofiamatulis sofiamatulis commented Dec 8, 2021

Why are these changes introduced?

Checklist

@katycobb
Copy link
Contributor

katycobb commented Dec 8, 2021

@sofiamatulis not totally sure if this is the correct issue, please let me know if not! For image banner, we'd like to add help text under the Desktop content position field to explain how this behaves on mobile: Position is automatically optimized for mobile.

Let me know if you need more info. cc @wiktoriaswiecicka

@sofiamatulis
Copy link
Contributor Author

@sofiamatulis not totally sure if this is the correct issue, please let me know if not! For image banner, we'd like to add help text under the Desktop content position field to explain how this behaves on mobile: Position is automatically optimized for mobile.

Let me know if you need more info. cc @wiktoriaswiecicka

@katycobb Since this will require new translations I will add this to this existing issue and we will create a follow up PR to include it #959 :)

@sofiamatulis sofiamatulis mentioned this pull request Dec 9, 2021
2 tasks
Copy link
Contributor

@martinamarien martinamarien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks Sofia.

Copy link
Contributor

@tyleralsbury tyleralsbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@sofiamatulis sofiamatulis merged commit 9070726 into main Dec 10, 2021
@sofiamatulis sofiamatulis deleted the bannerfollowup branch December 10, 2021 17:18
phapsidesGT pushed a commit to Gravytrain-UK/gt-shopify-dawn-theme that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants