Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ResizeObserver by Resize event #563

Closed
wants to merge 1 commit into from
Closed

Conversation

ludoboludo
Copy link
Contributor

@ludoboludo ludoboludo commented Sep 3, 2021

Why are these changes introduced?

Fixes #510

What approach did you take?

Replaced the ResizeObserver by a Resize event which applies to the window instead of just the slider element.

Other considerations

I still need to look into the IntersectionObserver but when I tested on a laptop that has Safari 12.1.2 and browserstack iOS 12, I didn't get errors like I did before and language selector, cart notification, slider and product modal do work.

From what I'm seeing it's just the sticky header and product recos that do not work. So product recos never show up and the header behave like a non sticky one, stays at the top of the page at all time, so you have to scroll back up to get to it.

Would this be acceptable enough ? I think it prevents us from having too many work arounds/extra code and offer a decent experience on those older browser versions.

Demo links

Checklist

Things to test
Use browserstack to test iOS 12 and the Mojave OS with version 12 for Safari.

  • local selector in the footer,
  • product modal,
  • cart notification,
  • and general functionality of the theme

@ludoboludo ludoboludo marked this pull request as ready for review September 3, 2021 15:08
@michaelburtonray
Copy link

michaelburtonray commented Sep 5, 2021

Is Safari 12 being supported? According to Theme requirements Only the latest two major releases of a browser need support (Safari 14 and Safari 13)

I thought the Dawn theme was supposed to be focusing on the latest browser APIs supported by evergreen browsers as opposed to bloating the codebase with fallbacks and polyfills.

@ludoboludo
Copy link
Contributor Author

You're right @michaelburtonray 👌 thanks for bringing it up. I will close the PR along with the issue.

@ludoboludo ludoboludo closed this Sep 7, 2021
@andrewetchen andrewetchen deleted the ios-12-support branch February 3, 2023 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Safari 12.1 support issues
2 participants