Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari 12.1 support issues #510

Closed
ludoboludo opened this issue Aug 27, 2021 · 1 comment
Closed

Safari 12.1 support issues #510

ludoboludo opened this issue Aug 27, 2021 · 1 comment
Assignees
Labels
Category: Bug Something isn't working Severity: 1 Urgent Severity

Comments

@ludoboludo
Copy link
Contributor

Describe the current behavior

Some of the things we're using aren't supported in Safari 12.1:

  • ResizeObserver, used for the sliders.
  • IntersectionObserver, used for the product recos and the header (specifically Safari on iOS)

Which breaks some functionalities:

  • local selector in the footer (not opening),
  • product modal (not opening),
  • cart notification (not showing up)

Describe the expected behavior

Ideally all those features mentioned above would work as expected.

Version information (Dawn, browsers and operating systems)

  • Dawn Version: 1.0.0
  • macOS Version 10.14
  • Safari version 12.1

Possible solution

When removing mentions of the ResizeObserver and IntersectionObserver it seem to work as expected. But we didn't look into how to replace what they're doing with a fallback.

Additional context/screenshots

@nicklepine nicklepine added Severity: 1 Urgent Severity Category: Bug Something isn't working labels Aug 31, 2021
@ludoboludo ludoboludo self-assigned this Sep 2, 2021
@ludoboludo
Copy link
Contributor Author

Good point from @michaelburtonray reminding me: According to Theme requirements Only the latest two major releases of a browser need support (Safari 14 and Safari 13)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Bug Something isn't working Severity: 1 Urgent Severity
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants