added media queries to align the drawer menu with announcement bar #2808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanie-shopify
approved these changes
Jul 11, 2023
| @@ -2304,13 +2299,25 @@ product-info .loading-overlay:not(.hidden) ~ *, | |||
| } | |||
|
|
|||
| @keyframes translateAnnouncementSlideIn { | |||
| 0% {opacity: 0; transform: translateX(var(--announcement-translate-from))} | |||
| 100% {opacity: 1; transform: translateX(0)} | |||
| 0% { | |||
There was a problem hiding this comment.
seems like just spacing changed here and no content- any reason?
responds to feedback on readme clarity in #2628 some devs had confusion on which version of dawn to use for client updates.
* Adjust height of announcement bar and sub-items. * Adjust announcement bar button height on desktop only. * Fix width of the utility bar on mobile. * Remove bizarre rem-based values.
* Add shadow opacity to dropdowns and pop-ups * Change from 10 to 5 Change from 10 to 5
* Cart items discount title fix * add fix to drawer * make sure it's line level discounts only
* added preset to apply outline button in image-with-text * Update 10 translation files * Update 10 translation files --------- Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
* fix: show accurate subtotal price for cart * chore: update subtotal in cart drawer * chore: update copy for estimated total, adjust spacing and placement * fix: use cart__footer selector for margin instead * fix: make copy sentence case * Update 20 translation files * Update 3 translation files * Update 7 translation files --------- Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
* Update auto-rotate for the announcement bar * Simplify the visibility rule. * Update 20 translation files * Auto-advance to the selected message when block is selected. --------- Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
| @@ -272,8 +272,8 @@ | |||
| "title": "Your cart", | |||
| "caption": "Cart items", | |||
| "remove_title": "Remove {{ title }}", | |||
| "subtotal": "Subtotal", | |||
| "new_subtotal": "New subtotal", | |||
| "estimated_total": "Estimated total", | |||
There was a problem hiding this comment.
Localization quality issue found
The following issues may affect the quality of localized translations if they are not addressed:
- The value
Estimated totalfor keysections.cart.estimated_totalis very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.
Please look out for other instances of this issue in your PR and fix them as well if possible.
Questions about these messages? Hop in the #help-localization Slack channel.
| @@ -448,7 +448,7 @@ | |||
| "name": "Announcement bar", | |||
| "settings": { | |||
| "auto_rotate": { | |||
| "label": "Auto-rotate on desktop" | |||
| "label": "Auto-rotate announcements" | |||
There was a problem hiding this comment.
Localization quality issue found
The following issues may affect the quality of localized translations if they are not addressed:
- The value
Auto-rotate announcementsfor keysections.announcement-bar.settings.auto_rotate.labelis very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.
Please look out for other instances of this issue in your PR and fix them as well if possible.
Questions about these messages? Hop in the #help-localization Slack channel.
|
"I have signed the CLA!" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
Menu drawer hamburger menu icon in the header aligns with social media icons in announcement and language/currency pickers align with cart icon in header in desktop view.
Why are these changes introduced?
Fixes #2748.
What approach did you take?
I added media queries to make the padding left and right in the header match the padding left and right in announcement when in desktop view and shrink it to the previous paddings when in mobile view.
Visual impact on existing themes
Announcement bar social icons and hamburger menu for drawer in the header are aligned
Testing steps/scenarios
Demo links
Checklist