Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove multirow section from header and footer groups #2237

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

eugenekasimov
Copy link
Contributor

@eugenekasimov eugenekasimov commented Jan 19, 2023

PR Summary:

Remove the ability to add the new Multirow section in both header and Footer group

Why are these changes introduced?

Fixes #2236 .

What approach did you take?

Other considerations

Decision log

# Decision Alternatives Rationale Downsides
1

Visual impact on existing themes

Testing steps/scenarios

  • Step 1

Demo links

Checklist

@eugenekasimov eugenekasimov marked this pull request as ready for review January 19, 2023 18:11
Copy link
Contributor

@melissaperreault melissaperreault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So fresh and so quick! Thanks Eugene! 🚢

@eugenekasimov eugenekasimov merged commit 01a0cb4 into main Jan 19, 2023
@eugenekasimov eugenekasimov deleted the remove-multirow-from-section-groups branch January 19, 2023 18:59
phapsidesGT pushed a commit to Gravytrain-UK/gt-shopify-dawn-theme that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent Multirow section to be added in the header and footer group
4 participants