Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent Multirow section to be added in the header and footer group #2236

Closed
melissaperreault opened this issue Jan 19, 2023 · 0 comments · Fixed by #2237
Closed

Prevent Multirow section to be added in the header and footer group #2236

melissaperreault opened this issue Jan 19, 2023 · 0 comments · Fixed by #2237
Assignees
@eugenekasimov
Labels
Category: Bug Something isn't working

Comments

@melissaperreault
Copy link
Contributor

melissaperreault commented Jan 19, 2023 •
edited
Loading

Describe the current behavior

Remove the ability to add the new Multirow section in both header and Footer group

Describe the expected behavior

Section that you should be able to add in:

Header group

  • Custom Liquid

Footer group

  • Custom Liquid
  • Email signup

Possible solution

If we don't want this new section to show up for header/footer groups then we can update the enabled_on / disabled_on prop in the section schema

Version information (Dawn, browsers and operating systems)

  • Dawn Version: 7.0.1
  • Chrome Version 108.0.5359.124
  • macOS Version 13.1
@melissaperreault melissaperreault added the Category: Bug Something isn't working label Jan 19, 2023
@clauderic clauderic changed the title Prevent Multirow section to be added in the Header group Prevent Multirow section to be added in the header and footer group Jan 19, 2023
@eugenekasimov eugenekasimov self-assigned this Jan 19, 2023
@ludoboludo ludoboludo assigned ludoboludo and unassigned ludoboludo Jan 19, 2023
@eugenekasimov eugenekasimov mentioned this issue Jan 19, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eugenekasimov eugenekasimov

Labels
Category: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove multirow section from header and footer groups Shopify/dawn
3 participants
@melissaperreault @ludoboludo @eugenekasimov