Fix facets nl translations #2207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We received feedback that in the context of a range slider, "tot" is the correct translation.
koenbouwmans
approved these changes
Jan 11, 2023
carolineschnapp
approved these changes
Jan 13, 2023
|
Hey folks, just sharing context here. Manually changing translation string doesn't really fix anything as it will conflict with what our translation platform thinks it should be. There is form we can fill to request a change instead which I went ahead and filled based on the description and screenshot in the PR 👍 You can get the form on slack by typing: |
phapsidesGT
pushed a commit
to Gravytrain-UK/gt-shopify-dawn-theme
that referenced
this pull request
Sep 3, 2024
Change nl translation for range picker "to"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
We received merchant feedback that in the context of a range slider, "tot" is the correct translation of "to".
Currently, Price filter says "Aan" in Dutch, screenshot. This translates to "on" in this context, not "to".
This changes it to say "Tot", screenshot
What approach did you take?
To see this in your store, you will need Dutch enabled as a Store language. Price filters will only appear for the store's default currency - hence why my screenshots above show USD prices with Dutch translations.
Checklist