Image setting updates #2148
Merged
Image setting updates #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c318ff3 to
8f8f3d9
Compare
eugenekasimov
previously approved these changes
Dec 2, 2022
LucasLacerdaUX
previously approved these changes
Dec 8, 2022
Comment on lines
-166
to
-196
| "label": "t:sections.image-banner.settings.adapt_height_first_image.label", | ||
| "info": "t:sections.image-banner.settings.adapt_height_first_image.info" |
There was a problem hiding this comment.
Should we remove these translation keys in en.default.schema.json?
There was a problem hiding this comment.
I actually did mean to initially. Do you know what happens if we do remove some? Do the generated strings end up getting removed from the other files async or anything or would we have to go and specifically delete them ourselves?
If there's no conflicts or anything I might just clean this up in another image with text related PR I have going so I don't have to pull this down again, if that's ok with you.
There was a problem hiding this comment.
I'm pretty sure it gets removed by the translation platform at some point if we remove it from the English file. But I'm okay with doing it on a separate PR.
There was a problem hiding this comment.
Hey team! Seems like the translation was not removed. TIL!
There is an open PR for removing it from our community #2482
3b9c9e6
0da5add to
cdbb6b3
Compare
Co-authored-by: Lucas Lacerda <37168033+LucasLacerdaUX@users.noreply.github.com>
eugenekasimov
approved these changes
Dec 19, 2022
TimmersThomas
added a commit
to TimmersThomas/shopify-template-houseofchocolate
that referenced
this pull request
Dec 28, 2022
* shopify/main: (57 commits) Change sticky header settings (Shopify#2165) Image setting updates (Shopify#2148) Update 1 translation file (Shopify#2183) Update 2 translation files (Shopify#2182) Fix mega-menu vertical shadow issue (Shopify#2147) Update translations: buyer (Shopify#2180) Change product recommendations name to related products (Shopify#2161) Update 2 translation files (Shopify#2178) Add default text for cart-notification link (Shopify#2167) Update 1 translation file (Shopify#2177) Update 20 translation files (Shopify#2176) Update 1 translation file (Shopify#2174) Updates to collage settings and defaults (Shopify#2150) Update 1 translation file (Shopify#2173) Update issue templates Update layout label (Shopify#2164) Search ux improvements (Shopify#2127) Prettier all liquid files [part 2] (Shopify#2126) [Footer] Add 'Show policy links' setting (Shopify#2084) [Header] Move 'Logo' to Global Theme settings (Shopify#2083) ...
phapsidesGT
pushed a commit
to Gravytrain-UK/gt-shopify-dawn-theme
that referenced
this pull request
Sep 3, 2024
* Update height settings for image banner, slideshow, image with text * Setting schema updates * Update 17 translation files * Update 2 translation files * Update 1 translation file * Fix formatting Co-authored-by: Lucas Lacerda <37168033+LucasLacerdaUX@users.noreply.github.com> Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> Co-authored-by: Lucas Lacerda <37168033+LucasLacerdaUX@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
Makes minor adjustment to image size settings for slideshow, image banner, and image with text.
Important: Removed a setting in image banner.
Why are these changes introduced?
Fixes #2133
What approach did you take?
Slide heightsetting fromAdapttoMediumAdapt section height to first image sizecheckbox setting with a newAdapt to first imageoption for existingBanner heightselect settingMediumoption to existingImage heightselect settingVisual impact on existing themes
Slideshow: Default slide height has changed. This could cause a visual change for sections that don't have a value for this setting defined, but this shouldn't be the case.
Image banner: The setting changes in image banner should be considered a breaking change. The same visual result is still achievable with the new option added to the banner height setting, but sections will need to be manually updated to use the new setting.
Testing steps/scenarios
Demo links
Checklist