Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering accessibility fixes #141

Merged
merged 1 commit into from
Jul 8, 2021
Merged

Filtering accessibility fixes #141

merged 1 commit into from
Jul 8, 2021

Conversation

tyleralsbury
Copy link
Contributor

@tyleralsbury tyleralsbury commented Jul 7, 2021

Why are these changes introduced?

Fix #115
Fix #113

What approach did you take?

Followed the recommended code changes by @svinkle for improving the accessibility of the filters.

Demo links

Checklist

@tyleralsbury tyleralsbury requested a review from svinkle July 7, 2021 19:23
@tauthomas01 tauthomas01 self-requested a review July 7, 2021 20:22
@tauthomas01 tauthomas01 self-assigned this Jul 7, 2021
Copy link
Contributor

@tauthomas01 tauthomas01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

@tyleralsbury tyleralsbury merged commit 144ff2a into main Jul 8, 2021
@tyleralsbury tyleralsbury deleted the filtering-fixes-2 branch July 8, 2021 13:47
phapsidesGT pushed a commit to Gravytrain-UK/gt-shopify-dawn-theme that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants