Skip to content

Commit

Permalink
Filtering accessibility fixes (#141)
Browse files Browse the repository at this point in the history
  • Loading branch information
@tyleralsbury
tyleralsbury authored Jul 8, 2021
1 parent 32c77de commit 144ff2a
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions sections/main-collection-product-grid.liquid
View file
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
<span class="field__currency">{{ cart.currency.symbol }}</span>
<input class="field__input"
name="{{ filter.min_value.param_name }}"
id="Filter-{{ filter.label | escape }}-{{ forloop.index }}"
id="Filter-{{ filter.label | escape }}-GTE"
{%- if filter.min_value.value -%}
{%- if uses_comma_decimals -%}
value="{{ filter.min_value.value | money_without_currency | replace: '.', '' | replace: ',', '.' }}"
Expand All @@ -108,13 +108,13 @@
min="0"
max="{{ filter.range_max | money_without_currency | replace: ',', '' }}">
</input>
<label class="field__label" for="Search-In-Modal">{{ 'sections.collection_template.from' | t }}</label>
<label class="field__label" for="Filter-{{ filter.label | escape }}-GTE">{{ 'sections.collection_template.from' | t }}</label>
</div>
<div class="field">
<span class="field__currency">{{ cart.currency.symbol }}</span>
<input class="field__input"
name="{{ filter.max_value.param_name }}"
id="Filter-{{ filter.label | escape }}-{{ forloop.index }}"
id="Filter-{{ filter.label | escape }}-LTE"
{%- if filter.max_value.value -%}
{%- if uses_comma_decimals -%}
value="{{ filter.max_value.value | money_without_currency | replace: '.', '' | replace: ',', '.' }}"
Expand All @@ -127,7 +127,7 @@
min="0"
max="{{ filter.range_max | money_without_currency | replace: ',', '' }}">
</input>
<label class="field__label" for="Search-In-Modal">{{ 'sections.collection_template.to' | t }}</label>
<label class="field__label" for="Filter-{{ filter.label | escape }}-LTE">{{ 'sections.collection_template.to' | t }}</label>
</div>
</div>
</price-range>
Expand Down Expand Up @@ -292,7 +292,7 @@
<span class="field__currency">{{ cart.currency.symbol }}</span>
<input class="field__input"
name="{{ filter.min_value.param_name }}"
id="Filter-{{ filter.label | escape }}-{{ forloop.index }}"
id="Mobile-Filter-{{ filter.label | escape }}-GTE"
{%- if filter.min_value.value -%}
{%- if uses_comma_decimals -%}
value="{{ filter.min_value.value | money_without_currency | replace: '.', '' | replace: ',', '.' }}"
Expand All @@ -305,13 +305,13 @@
min="0"
max="{{ filter.range_max | divided_by: 100 | ceil }}">
</input>
<label class="field__label" for="Search-In-Modal">{{ 'sections.collection_template.from' | t }}</label>
<label class="field__label" for="Mobile-Filter-{{ filter.label | escape }}-GTE">{{ 'sections.collection_template.from' | t }}</label>
</div>
<div class="field">
<span class="field__currency">{{ cart.currency.symbol }}</span>
<input class="field__input"
name="{{ filter.max_value.param_name }}"
id="Filter-{{ filter.label | escape }}-{{ forloop.index }}"
id="Mobile-Filter-{{ filter.label | escape }}-LTE"
{%- if filter.max_value.value -%}
{%- if uses_comma_decimals -%}
value="{{ filter.max_value.value | money_without_currency | replace: '.', '' | replace: ',', '.' }}"
Expand All @@ -324,7 +324,7 @@
min="0"
max="{{ filter.range_max | divided_by: 100 | ceil }}">
</input>
<label class="field__label" for="Search-In-Modal">{{ 'sections.collection_template.to' | t }}</label>
<label class="field__label" for="Mobile-Filter-{{ filter.label | escape }}-LTE">{{ 'sections.collection_template.to' | t }}</label>
</div>
</price-range>
</div>
Expand Down Expand Up @@ -411,7 +411,7 @@
</div>
</div>

<p class="collection-product-count light">
<p class="collection-product-count light" role="status">
{{ 'sections.collection_template.product_count' | t: product_count: collection.products_count, count: collection.all_products_count }}
</p>

Expand All @@ -432,7 +432,7 @@
</div>
</div>

<p class="collection-product-count light">
<p class="collection-product-count light" role="status">
{{ 'sections.collection_template.product_count' | t: product_count: collection.products_count, count: collection.all_products_count }}
</p>

Expand Down

0 comments on commit 144ff2a

Please sign in to comment.