only replace font urls when content type is not present or it is a text #1867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Coverage report
Test suite run success1133 tests passing in 548 suites. Report generated by 🧪jest coverage report action from eb0f06f |
amcaplan
reviewed
May 1, 2023
packages/cli-kit/assets/cli-ruby/test/shopify-cli/theme/dev_server/cdn_fonts_test.rb
Show resolved
Hide resolved
joshuamsager
approved these changes
May 1, 2023
JLoppert
approved these changes
May 1, 2023
| if content_type.nil? || content_type == "" || content_type&.start_with?("text/") | ||
| Rack::Response.new(replace_font_urls(body), status, headers).finish | ||
| else | ||
| Rack::Response.new(body, status, headers).finish |
There was a problem hiding this comment.
I was concerned that this changes the response type from an array to an object, but this returns the same 3 tuple array.
https://www.rubydoc.info/github/rack/rack/Rack%2FResponse:finish
👍
amcaplan
approved these changes
May 2, 2023
|
By the way, PLEASE do add a changeset before merging. So we can include the fix in the changelog. |
|
And the changeset should be patch-level! |
isaacroldan
approved these changes
May 2, 2023
6 tasks
|
Is this good for a changeset entry? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes https://github.com/Shopify/assets/issues/653
New vanity urls are breaking theme development
related to #1862
WHAT is this pull request doing?
Ensure the fonts url replacement only happens on text assets (or when content type is not present)
How to test your changes?
bundle exec rake test TEST=test/shopify-cli/theme/dev_server/cdn_fonts_test.rbOR
Measuring impact
How do we know this change was effective? Please choose one:
Checklist
devordeployhave been reflected in the internal flowchart.