-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vanity url support for embedded URLs #1862
Conversation
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
f00b307
to
48e59c5
Compare
packages/cli-kit/assets/cli-ruby/lib/shopify_cli/theme/dev_server/local_assets.rb
Outdated
Show resolved
Hide resolved
957beeb
to
2c0df3f
Compare
2c0df3f
to
809b697
Compare
Coverage report
Test suite run success1131 tests passing in 548 suites. Report generated by 🧪jest coverage report action from 1eda576 |
We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. lets wait for the owners approval
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't 100% figure out how to 🎩 but the code change is small and the test is pretty clear. I assume @yknx4 already did due diligence on the completeness of the fix.
Currently, only cdn.shopify.com links are rewritten when they are embedded in CSS/JS. This change also supports links that are served off of the shop's host.
WHY are these changes introduced?
Bugfix; without this, shops with vanity domains on their shop will have trouble loading their scripts locally.
Part of: #1859
WHAT is this pull request doing?
Simple
gsub
How to test your changes?
Visit a shop with query param:
?force_vanity_url=true
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist
dev
ordeploy
have been reflected in the internal flowchart.