feat(Modal): Add closeIcon #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -45,9 +47,18 @@ class Modal extends Component { | |||
| /** Additional classes. */ | |||
| className: PropTypes.string, | |||
|
|
|||
| /** Icon */ | |||
| closeIcon: PropTypes.oneOfType([ | |||
| PropTypes.node, | |||
There was a problem hiding this comment.
How about allowing boolean as well? I would think closeIcon alone would be the primary use case for this prop.
|
I believe this also fixes #436, if so, want to update the description to close it on merge? |
|
@levithomason - you're right, added that issue to the description 👍 |
|
Cool, what do you think about the boolean prop for the default |
|
Added in da00365 👍 |
|
👍 will merge on pass |
levithomason
approved these changes
Nov 23, 2016
Current coverage is 100% (diff: 100%)@@ master #932 diff @@
====================================
Files 137 137
Lines 2262 2267 +5
Methods 0 0
Messages 0 0
Branches 0 0
====================================
+ Hits 2262 2267 +5
Misses 0 0
Partials 0 0
|
|
Released in |
Arthelon
pushed a commit
to Arthelon/Semantic-UI-React
that referenced
this pull request
Nov 23, 2016
* feat(Modal): Add closeIcon * Default closeIcon to `close` if closeIcon=true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #436
Given #893 is a little controversial due to the reliance on the DOM and data props, this solves a more acute need of adding a close icon to the
Modal, which is standard in SUI core (see http://semantic-ui.com/modules/modal.html#/usage):While this mixes shorthand with children, I think it's reasonable given:
Message: https://github.com/Semantic-Org/Semantic-UI-React/blob/master/src/collections/Message/Message.js#L74-L81)openstate yourself, which I think is overkill for something as simple/common as the close icon.closeIcon='whatever'. And even then, by default it's absolutely positioned so it doesn't affect the rest of the markup at all.