Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal: Support showing Close (X) Icon #436

Closed
brsanthu opened this issue Aug 25, 2016 · 3 comments · Fixed by #932
Closed

Modal: Support showing Close (X) Icon #436

brsanthu opened this issue Aug 25, 2016 · 3 comments · Fixed by #932

Comments

@brsanthu
Copy link
Contributor

It would be nice if we can specify a prop to show close (x) icon on the top right corner, which would close the model and fires onClose or onHide.

@levithomason
Copy link
Member

I'd merge a PR for this. It should be very easy since we already have close listeners setup. We'd just need to include an icon prop and add the close handler. Probably default the icon to close but allow it to be configured via props.

@brsanthu
Copy link
Contributor Author

@levithomason you are so fast :)

What you say makes sense. I will try to take a look and create a PR.

@brsanthu brsanthu changed the title Support showing Close (X) Icon in Modal Modal: Support showing Close (X) Icon Aug 25, 2016
@levithomason
Copy link
Member

I hate waiting :/ So, I hate making ppl wait 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants