Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Safari private mode localStorage #333

Merged
merged 2 commits into from
Jul 13, 2016

Conversation

levithomason
Copy link
Member

@levithomason levithomason commented Jul 13, 2016

Fixes #332.

@codecov-io
Copy link

codecov-io commented Jul 13, 2016

Current coverage is 90.51%

Merging #333 into master will increase coverage by 0.87%

@@             master       #333   diff @@
==========================================
  Files            67         57    -10   
  Lines           927        717   -210   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits            831        649   -182   
+ Misses           96         68    -28   
  Partials          0          0          

Powered by Codecov. Last updated by c114bc0...b6a2914

@dvdzkwsk
Copy link
Member

👻

@levithomason levithomason merged commit e0c86b0 into master Jul 13, 2016
@levithomason levithomason deleted the feature/fix-safari-localstorage branch July 13, 2016 18:59
@eliasliedholm
Copy link

🙌 thank you!

jhchill666 pushed a commit to jhchill666/stardust that referenced this pull request Jul 19, 2016
* fix(debug): wrap localStorage in try/catch

* chore(codecov): add yml and ignore src/utils
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants