Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting localStorage throws in Safari private mode #332

Closed
levithomason opened this issue Jul 13, 2016 · 0 comments
Closed

Setting localStorage throws in Safari private mode #332

levithomason opened this issue Jul 13, 2016 · 0 comments
Labels

Comments

@levithomason
Copy link
Member

levithomason commented Jul 13, 2016

Per the gitter issue from @eliasliedholm:

Hi, I’m running into a problem when using Stardust in safari private mode, because safari does not allow the debugger tool to write to the localStorage object, and will throw an exception. I found that in runtime, process.env.NODE_ENV is undefined, so the debugger will be added even in production, which means safari private mode will always crash.

Was wondering if you knew a way to get around it?

We use debug for this and this is a known issue with the way it is configured in the browser: debug-js/debug#167.

I'm adding this as a bug. We should wrap our localStorage use in a try/catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant