fix(Dropdown): fix crash when setting defaultOpen on a search dropdown #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levithomason
requested changes
Dec 8, 2016
| } | ||
|
|
||
| componentDidMount() { | ||
| const { open } = this.state |
There was a problem hiding this comment.
Because open() sets state, this results in setting state on mount which is an antipattern. We have a lint rule for this enabled, although, because it is indirect and abstracted away, it is not picking up on it.
I think we should instead add guarding logic where the focus() is called and only call it if there is a node present.
d0e6f43 to
eadd0e3
Compare
levithomason
approved these changes
Dec 9, 2016
|
Thanks much! |
|
Releasing now as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the this.open() call happens inside componentWillMount(), the search input hasn't been built yet and the this._search.focus() crashes. This simply moves the open call to a componentDidMount() function