fix(Dropdown): fix crash when setting defaultOpen on a search dropdown

Semantic-Org · Dec 8, 2016 · d0e6f43 · d0e6f43
1 parent 5a1b82d
commit d0e6f43
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/modules/Dropdown/Dropdown.js b/src/modules/Dropdown/Dropdown.js
@@ -335,9 +335,13 @@ export default class Dropdown extends Component {
   componentWillMount() {
     if (super.componentWillMount) super.componentWillMount()
     debug('componentWillMount()')
-    const { open, value } = this.state
+    const { value } = this.state
 
     this.setValue(value)
+  }
+
+  componentDidMount() {
+    const { open } = this.state
     if (open) this.open()
   }
 

diff --git a/test/specs/modules/Dropdown/Dropdown-test.js b/test/specs/modules/Dropdown/Dropdown-test.js
@@ -867,6 +867,10 @@ describe('Dropdown Component', () => {
       wrapperShallow(<Dropdown options={options} selection defaultOpen />)
       dropdownMenuIsOpen()
     })
+    it('defaultOpen opens the menu on search dropdowns', () => {
+      wrapperShallow(<Dropdown search options={options} selection defaultOpen />)
+      dropdownMenuIsOpen()
+    })
     it('defaultOpen closes the menu when false', () => {
       wrapperShallow(<Dropdown options={options} selection defaultOpen={false} />)
       dropdownMenuIsClosed()