Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow inclusion of ongoing events in event time filter #120

Merged
merged 2 commits into from
Nov 15, 2022

Conversation

Flix6x
Copy link
Collaborator

@Flix6x Flix6x commented Nov 7, 2022

In FlexMeasures, I'm planning to move towards using these two new filters to replace the ones we use now, as to include events that are ongoing at the edges of the selected event time window. That is, I intend to replace the use of event_starts_after with event_ends_after, and likewise, to replace the use of event_ends_before with event_starts_before. In FlexMeasures, I am thinking of simplifying the filter names to events_after and events_before (and document that they may include events that partially transpire outside of this time window), while in timely-beliefs, I'd like to keep the explicit names.

@Flix6x Flix6x merged commit 009a602 into main Nov 15, 2022
@Flix6x Flix6x deleted the allow-inclusion-of-ongoing-events-in-event-time-filter branch November 15, 2022 22:06
@Flix6x Flix6x added this to the 1.14.0 milestone Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Database support Dealing with databases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants