Allow inclusion of ongoing events in event time filter #120
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In FlexMeasures, I'm planning to move towards using these two new filters to replace the ones we use now, as to include events that are ongoing at the edges of the selected event time window. That is, I intend to replace the use of
event_starts_after
withevent_ends_after
, and likewise, to replace the use ofevent_ends_before
withevent_starts_before
. In FlexMeasures, I am thinking of simplifying the filter names toevents_after
andevents_before
(and document that they may include events that partially transpire outside of this time window), while in timely-beliefs, I'd like to keep the explicit names.