Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 482 add scheduling test for maximizing self consumption #532

Merged
merged 47 commits into from
Nov 21, 2022
Merged

Issue 482 add scheduling test for maximizing self consumption #532

merged 47 commits into from
Nov 21, 2022

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Nov 11, 2022 •
edited
Loading

Closes #482.

This PR also adds a workaround for a still open flexmeasures issue that is waiting on a not yet merged timely-beliefs PR. This was needed to support looking up sensor data for a tariff sensor with the at_date knowledge horizon function. That test sensor now contains a single data point that defines the price for the entire year, and a search for data for any subperiod within that year should return the price valid during that period.

nhoening and others added 30 commits October 29, 2022 20:36
@nhoening
Better documentation of flexibility model for storage in endpoint; re…
ce8169c 
…factor its parameters and handling within the code for readability

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
add changelog entry
3bed7c0 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
make tests work, include updating older API versions, make prefer_cha…
1fba29e 
…rging_sooner part of storage specs & an optional parameter in API v3

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
use storage_specs in CLI command, as well
0e9259d 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
remove default resolution of 15M, for now pass in what you want
c2b2787 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
various review comments
c0400ae 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
black
4718a8a 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
fix tests
2eef27d 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
always load sensor when checking storage specs
1f68659 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
begin to handle source model and version during scheduling
2beb928 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
we can get multiple sources from our query (in the old setting, when …
378caba 
…we use name, but also in the new setting, unless we always include the user_id)

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
give our two in-built schedulers an official __author__ and __version__
5b48baf 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
review comments
b664910 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
refactor getting data source for a job to util function; use the actu…
e9ff60b 
…al data source ID for this lookup if possible

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
pass sensor to check_storage_specs, as we always have it already
5fe72dc 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
wrap Scheduler in classes, unify data source handling a bit more
f80171d 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
Merge branch 'main' into refactor-scheduling-storage-specs
c04f0d7 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@Flix6x
Support pandas 1.4 (#525)
22cb852 
Add a pandas version check in initialize_index.


* Use initialize_series util function

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Update initialize_index for pandas>=1.4

Signed-off-by: F.N. Claessen <felix@seita.nl>

* flake8

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Use initialize_index or initialize_series in all places where the closed keyword argument was used

Signed-off-by: F.N. Claessen <felix@seita.nl>

* flake8

Signed-off-by: F.N. Claessen <felix@seita.nl>

* mypy: PEP 484 prohibits implicit Optional

Signed-off-by: F.N. Claessen <felix@seita.nl>

* black after mypy

Signed-off-by: F.N. Claessen <felix@seita.nl>

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Stop requiring min/max SoC attributes, which have defaults:
dd47dab 
- Default min = 0
- Default max = the highest target value, or np.nan if there are no targets, which subsequently maps to infinity in our solver

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Set up device constraint columns for efficiencies in Charge Point sch…
add377f 
…eduler, too

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Derive flow constraints for battery scheduling, too (copied from Char…
ccab2ee 
…ge Point scheduler)

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Refactor: rename BatteryScheduler to StorageScheduler
6344cb0 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Warn for deprecation of
7f9eced 
schedule_battery and schedule_charging_station

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Use StorageScheduler instead of ChargingStationScheduler
4bc593c 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Deprecate ChargingStationScheduler
ec40bc0 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Refactor: move StorageScheduler to dedicated module
6914a4b 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Update docstring
5e6bd4e 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
fix test
beb2770 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
flake8
3bf1b97 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Merge remote-tracking branch 'origin/main' into refactor-scheduling-s…
ed3284d 
…torage-specs

# Conflicts:
#	documentation/changelog.rst
@Flix6x
Refactor: rename module
ad22c35 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Deal with empty SoC targets
4efe883 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Stop wrapping DataFrame representations in logging
09cf700 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Log warning instead of raising UnknownForecastException, and assume z…
5a3845d 
…ero power values for missing values

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Workaround for GH #484
4713de1 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Test maximizing self-consumption
0780d53 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Refactor: a single parameterized test instead of 2 tests with a lot o…
51e5809 
…f duplicate code

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Remove debug statements
ffec586 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x self-assigned this Nov 11, 2022
@Flix6x
black
66e84cc 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Correct mistake while refactoring
5bb7751 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@coveralls
Copy link
Collaborator

coveralls commented Nov 11, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3518285555

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 65.002%
Totals Coverage Status
Change from base Build 3495120819: 0.03%
Covered Lines: 6586
Relevant Lines: 9513
💛 - Coveralls

@Flix6x Flix6x marked this pull request as ready for review November 11, 2022 15:05
@Flix6x Flix6x requested a review from nhoening November 11, 2022 15:05
@Flix6x Flix6x added this to the 0.12.0 milestone Nov 11, 2022
nhoening
nhoening requested changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, some comments for clarification of intentions.

@nhoening
Copy link
Contributor

Also, no changelog entry?

@Flix6x
Check default price sensor in both scenarios
3dda0e8 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Expand explanation of optimization context
2fac4f5 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Reorder assertions and add more comments
8343eba 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Copy link
Contributor Author

Flix6x commented Nov 17, 2022

By now, that timely-beliefs PR has been merged. So I would remove the workaround and update timely-beliefs instead.

Also, no changelog entry?

What's your stance on changelog entries for adding tests that did not result in any changed logic? It's not a bug fix. So, under the infrastructure category?

@nhoening
Copy link
Contributor

Yes. Let's not do this with all tests, but this one seems cool.

Base automatically changed from refactor-scheduling-storage-specs to main November 18, 2022 07:50
@Flix6x
Merge remote-tracking branch 'origin/main' into issue-482_Add_schedul…
7790492 
…ing_test_for_maximizing_self-consumption

# Conflicts:
#	documentation/changelog.rst
#	flexmeasures/data/models/planning/tests/test_solver.py
@Flix6x
Upgrade timely-beliefs to partly resolve workaround
17148d6 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
changelog entry
f84c200 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x requested a review from nhoening November 21, 2022 21:32
@Flix6x Flix6x merged commit 3c95759 into main Nov 21, 2022
@Flix6x Flix6x deleted the issue-482_Add_scheduling_test_for_maximizing_self-consumption branch November 21, 2022 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhoening nhoening nhoening approved these changes

Assignees

@Flix6x Flix6x

Labels
None yet
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.

Add scheduling test for maximizing self-consumption
3 participants
@Flix6x @coveralls @nhoening