-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CORS Filter #1286
CORS Filter #1286
Conversation
Adds CORS filter and Functional test
…xist in GemStone)
@eMaringolo I fixed the code for Gemstone and added an automated test for the CORS filter. The starting of the additional adaptor for the tests needs to be different for Gemstone. I’ll take a look later, and if it proves too difficult, we will mark it an expected failure for Gemstone. |
Thank you @jbrichau, I don't have a GemStone environment to make any change or running the tests. |
…adaptor at this time...
@eMaringolo I'm fiddling with the testcase I made for it using Parasol. I want to make the test work in GemStone and will finish it asap. Then we're of for release 3.4.6! |
…request. This makes it easier to execute the test on GemStone.
@eMaringolo I had to fix the CORSFilter for GemStone because I also finally was able to get the testing to work and now... the github CI actions are failing to execute the tests for some reason or another... sigh, sometimes it sucks doing software development.... |
…webapp running in the other gem
…s adaptor and added an assertion to try fixing why the test fails on github CI for GemStone builds
Thank you @jbrichau , next time I won't create any functional test that causes this much trouble! 😂 |
#1274 to master