Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS Filter #1286

Merged
merged 18 commits into from
Oct 3, 2021
Merged

CORS Filter #1286

merged 18 commits into from
Oct 3, 2021

Conversation

jbrichau
Copy link
Member

#1274 to master

@jbrichau
Copy link
Member Author

@eMaringolo I fixed the code for Gemstone and added an automated test for the CORS filter.

The starting of the additional adaptor for the tests needs to be different for Gemstone. I’ll take a look later, and if it proves too difficult, we will mark it an expected failure for Gemstone.

@eMaringolo
Copy link
Contributor

Thank you @jbrichau, I don't have a GemStone environment to make any change or running the tests.

@jbrichau
Copy link
Member Author

@eMaringolo I'm fiddling with the testcase I made for it using Parasol. I want to make the test work in GemStone and will finish it asap. Then we're of for release 3.4.6!

Johan Brichau added 2 commits September 27, 2021 19:36
@jbrichau
Copy link
Member Author

@eMaringolo I had to fix the CORSFilter for GemStone because String>>join: does not exist in GemStone.

I also finally was able to get the testing to work and now... the github CI actions are failing to execute the tests for some reason or another... sigh, sometimes it sucks doing software development....

@jbrichau jbrichau merged commit cb36af3 into master Oct 3, 2021
@jbrichau jbrichau deleted the 1270-CORS branch October 3, 2021 09:02
@eMaringolo
Copy link
Contributor

Thank you @jbrichau , next time I won't create any functional test that causes this much trouble! 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants