Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds CORS filter and Functional test #1274

Merged
merged 1 commit into from
Sep 19, 2021
Merged

Conversation

eMaringolo
Copy link
Contributor

I implemented a basic CORS filter with a functional test (including setting up a separate server adaptor to handle cross-origin requests).

It would be great to merge this into the upcoming release, so it can be ported to VAST (and other dialects).

@eMaringolo
Copy link
Contributor Author

This solves #1270

@eMaringolo
Copy link
Contributor Author

@jbrichau Can this be merged? :-)

@jbrichau
Copy link
Member

jbrichau commented Sep 1, 2021

@jbrichau Can this be merged? :-)

Sorry for the unresponsiveness. I'm swimming in too much things at once. I will test this hopefully this week!

@jbrichau
Copy link
Member

@eMaringolo I did not notice before that the Gemstone builds are failing here. This is probably because of incompatibility. We will need to fix this before this can be merged.

@eMaringolo
Copy link
Contributor Author

@jbrichau But the incompatibility is caused by something else, right? Looking at the job details, the failing tests have nothing to do with my proposed changes, or do they?

@jbrichau
Copy link
Member

The failing tests are testSentButNotImplemented and testUndefinedSymbols. These tests fail because there is code added that sends unimplemented messages and references undefined symbols.

I'm guessing it's in the example code, which is not part of a test so no other tests will fail.

expandMacrosWith: is probably the unimplemented message in GemStone.

@jbrichau jbrichau changed the base branch from master to 1270-CORS September 19, 2021 06:35
@jbrichau jbrichau merged commit 2897a0a into SeasideSt:1270-CORS Sep 19, 2021
@jbrichau
Copy link
Member

@eMaringolo I merged this in a branch to be able to debug and fix the broken tests in GemStone.

@jbrichau jbrichau mentioned this pull request Sep 19, 2021
@eMaringolo
Copy link
Contributor Author

Thank you very much Johan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants