Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update CONTRIBUTING.md #4165

Merged
merged 2 commits into from
Jun 2, 2021
Merged

Conversation

bjlittle
Copy link
Member

@bjlittle bjlittle commented Jun 1, 2021

🚀 Pull Request

Description

Minor update to our CONTRIBUTING.md


Consult Iris pull request check list

@bjlittle
Copy link
Member Author

bjlittle commented Jun 1, 2021

Okay, so I can only suggest that there is a nose testing race condition occurring in py37 as #4166 is cut from the same master commit as this PR, and yet #4166 CI tests all passed 🤔

This is addressed (superficially) in #4163

@bjlittle
Copy link
Member Author

bjlittle commented Jun 2, 2021

I'll rebase this PR once #4163 lands...

@trexfeathers
Copy link
Contributor

@bjlittle do you fancy linking to your friendly 'welcome Issue' {#4133) here?

@bjlittle
Copy link
Member Author

bjlittle commented Jun 2, 2021

We should also complement this with a SUPPORT.md ... but I'll do that as a separate PR 👍

@bjlittle bjlittle force-pushed the update-contributing branch from 66ced26 to 9c04fc4 Compare June 2, 2021 10:34
@bjlittle
Copy link
Member Author

bjlittle commented Jun 2, 2021

@trexfeathers I waxed it somewhat more lyrical... do tell me to calm down if you think I've missed the mark 😆

@bjlittle bjlittle force-pushed the update-contributing branch from 9c04fc4 to 9c5828d Compare June 2, 2021 10:55
@trexfeathers
Copy link
Contributor

image

@trexfeathers
Copy link
Contributor

I still have no idea how to fix the above, but I just thought I'd put it there.

@trexfeathers trexfeathers merged commit ca4c0d9 into SciTools:master Jun 2, 2021
@bjlittle
Copy link
Member Author

bjlittle commented Jun 2, 2021

@trexfeathers Awesome, thanks 🍻

I don't know if anything needs fixed... but maybe we could streamline somehow.

That said, if all roads lead to new contributions and GH discussions... then I'm not going to complain a jot 😉

tkknight added a commit to tkknight/iris that referenced this pull request Jun 4, 2021
* master:
  refactor setup.py to setup.cfg (SciTools#4168)
  update docs pypi release (SciTools#4173)
  Update CI environment lockfiles (SciTools#4137)
  update CONTRIBUTING.md (SciTools#4165)
  RTD support link update (SciTools#4166)
  drop py36 support (SciTools#4163)
  github issues contact link for discussions (SciTools#4164)
  Bump black version (SciTools#4162)
  Stop CI from clobbering commits on lockfile updates (SciTools#4157)
  [pre-commit.ci] pre-commit autoupdate (SciTools#4161)
  Add a method to return a CubeList from CubeList.copy() (SciTools#4094)
  Update black et al (SciTools#4155)
@bjlittle bjlittle deleted the update-contributing branch June 4, 2021 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants