Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop CI from clobbering commits on lockfile updates #4157

Merged
merged 10 commits into from
Jun 1, 2021

Conversation

jamesp
Copy link
Member

@jamesp jamesp commented May 26, 2021

🚀 Pull Request

Description

Added a step to the update lockfile workflow to first check if someone has committed to the auto-update-lockfiles branch since last run. If so, it will abort regenerating lockfiles.

This resolves #4156 (observed in #4137).

If you really want to run the workflow and potentially clobber anything on the branch, you can override this new check step by running from the actions panel and performing a manual workflow dispatch, setting the "clobber" value to YES.


Consult Iris pull request check list

@jamesp jamesp requested a review from trexfeathers May 26, 2021 10:58
@jamesp jamesp changed the title Ci lockfile fix Stop CI from clobbering commits on lockfile updates May 26, 2021
Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesp LGTM, let's give it whizz.

However, is it worthwhile capturing the no clobber and manual override step in the developer docs?

@jamesp jamesp requested a review from bjlittle May 26, 2021 16:36
@bjlittle bjlittle merged commit 8a7e6aa into SciTools:master Jun 1, 2021
@bjlittle
Copy link
Member

bjlittle commented Jun 1, 2021

@jamesp Awesome stuff. I ❤️ it!

tkknight added a commit to tkknight/iris that referenced this pull request Jun 4, 2021
* master:
  refactor setup.py to setup.cfg (SciTools#4168)
  update docs pypi release (SciTools#4173)
  Update CI environment lockfiles (SciTools#4137)
  update CONTRIBUTING.md (SciTools#4165)
  RTD support link update (SciTools#4166)
  drop py36 support (SciTools#4163)
  github issues contact link for discussions (SciTools#4164)
  Bump black version (SciTools#4162)
  Stop CI from clobbering commits on lockfile updates (SciTools#4157)
  [pre-commit.ci] pre-commit autoupdate (SciTools#4161)
  Add a method to return a CubeList from CubeList.copy() (SciTools#4094)
  Update black et al (SciTools#4155)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CI Lockfiles clobbers any commits to the auto-update-lockfiles branch
2 participants