Feature/add conversation logger merged

[emrgnt-cmplxty]

Important

This PR adds a conversation logging feature with history and branching support, updates API endpoints, models, and tests to manage conversations effectively.

• Behavior:
  • Adds conversation logging feature with support for conversation history and branching in core/base/logging/run_logger.py.
  • Introduces new API endpoint /v2/conversations/{conversation_id} in management_router.py to retrieve conversation history.
  • Updates agent_app in retrieval_router.py to handle conversation IDs and branching.
• Models:
  • Adds WrappedConversationResponse in management/responses.py for conversation data.
  • Updates RAGAgentResponse in retrieval/responses.py to include conversation_id.
• Tests:
  • Adds tests for conversation logging in test_chat_logging_provider.py.
  • Adds integration test test_conversation_history_sdk in runner_sdk.py.
• Misc:
  • Removes score_completion functionality from management_router.py and related files.
  • Updates Message class in llm.py to support new conversation features.

^{This description was created by for 81eef69. It will automatically update as commits are pushed.}

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
yc_demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 13, 2024 5:06pm
yc-demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 13, 2024 5:06pm

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
recommendation_platform	⬜️ Ignored (Inspect)			Oct 13, 2024 5:06pm

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 81eef69 in 1 minute and 21 seconds

More details

• Looked at 2662 lines of code in 41 files
• Skipped 0 files when reviewing.
• Skipped posting 5 drafted comments based on config settings.

1. py/core/agent/base.py:54

• Draft comment:
  The arun method has a TODO comment indicating it should return a list of messages. Ensure this is implemented as intended.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The arun method in py/core/agent/base.py has a TODO comment indicating that it should return a list of messages. This is a clear indication that the current implementation might not be complete or correct as per the intended design.

2. py/core/base/logging/run_logger.py:132

• Draft comment:
  The edit_message method creates a new branch and message. Ensure this doesn't lead to unnecessary data duplication.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The edit_message method in py/core/base/logging/run_logger.py creates a new branch and a new message when editing. This might lead to unnecessary data duplication if not handled properly. Consider optimizing this process.

3. py/core/base/logging/run_logger.py:303

• Draft comment:
  The get_conversation method returns an empty list if no branches are found. Consider raising an exception or returning a more informative response.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The get_conversation method in py/core/base/logging/run_logger.py returns an empty list if no branches are found. This might not be the best way to handle this case, as it could lead to confusion. Consider raising an exception or returning a more informative response.

4. py/core/main/api/retrieval_router.py:216

• Draft comment:
  The agent_app function has both message and messages parameters, with messages marked as deprecated. Consider removing the deprecated parameter to avoid confusion.
• Reason this comment was not posted:
  Confidence changes required: 50%
  In py/core/main/api/retrieval_router.py, the agent_app function has both message and messages parameters, with messages marked as deprecated. This could lead to confusion. Consider removing the deprecated parameter.

5. py/core/main/services/retrieval_service.py:370

• Draft comment:
  Remove or replace the print statement with proper logging.
• Reason this comment was not posted:
  Confidence changes required: 50%
  In py/core/main/services/retrieval_service.py, the agent method has a print statement for debugging purposes. This should be removed or replaced with proper logging before merging.

Workflow ID: wflow_pqTDm2WhIpjlSpEK

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.